broadlink: upgrade lib #1984
Merged
broadlink: upgrade lib #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrovato
force-pushed
the
broadlink-upgrade-lib
branch
from
4763010
to
fae8f16
Compare
|
I tested it with already setup device. There is no breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1984 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 786 786
Lines 12307 12307
=======================================
Hits 12085 12085
Misses 222 222 ☔ View full report in Codecov by Sentry. |
Job #2216: Bundle Size — 9.12MiB (0%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
| Current Job #2216 |
Baseline Job #2198 |
|
|---|---|---|
 |
4.93MiB |
4.93MiB |
|
302.47KiB |
302.47KiB |
|
0% |
0% |
|
51 |
51 |
|
158 |
158 |
|
1422 |
1422 |
|
20 |
20 |
|
0.83% |
0.83% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
| Current Job #2216 |
Baseline Job #2198 |
|
|---|---|---|
|
6.6MiB |
6.6MiB |
|
2.08MiB |
2.08MiB |
|
318.98KiB |
318.98KiB |
|
93.55KiB |
93.55KiB |
|
16.14KiB |
16.14KiB |
|
13.58KiB |
13.58KiB |
View job #2216 report View atrovato:broadlink-upgrade-lib branch activity
atrovato
force-pushed
the
broadlink-upgrade-lib
branch
from
fae8f16
to
2055385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translationson front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Upgrade broadlink lib to respond to https://community.gladysassistant.com/t/etude-de-faisabilite-arreter-poeles-a-granule/8490/9?u=alextrovato